Code Review Checklist

14 Information Management 2 class Donna (responsible for form design and part code writing and checking procedures) Van Yaya (part code and check procedure and write code review checklist)

1. Overview section

(1) Can the code meet the requirements and specifications?

Answer: Can

(2) Does the code design have thoughtful consideration?

Answer: Yes

(3) What is the readability of the code?

Answer: Can read

(4) is the code easy to maintain?

Answer: can run out

(5) Did each line of the code be executed and checked?

Answer: Check the

2. Design Specification Section

(1) Does the design conform to a known design pattern or a commonly used pattern in a project?

Answer: Yes

(2) Are there hard codes or strings/numbers that exist?

Answer: No

(3) Does the code depend on a platform and will affect future migrations (such as Win32 to Win64)?

Answer: no impact.

(4) Can the developer's new code be implemented with the functionality of the existing library/sdk/framework? Is there a similar feature in this project that can be called without being fully re-implemented?

A: 1. can be achieved 2. No

(5) Is there any useless code to erase? (A lot of people want to keep as much code as possible, because it might be used later, so there are a lot of commented-out code in the program file that can be deleted because the source control has saved the old code.) ）

A: There may be useless code, but it's not deleted. Because the error occurs after the deletion.

3. Code Specification Section

(1) Does the modified part conform to the Code standard and style (detailed provisions slightly)?

A: Compliant.

4. Specific Code section

(1) Are there any errors to be dealt with? For the external function that was called, did you check the return value or handled the exception?

Answer: The error is handled and corrected. And after the correction has been examined.

(2) is the parameter passed with or without errors, the length of the string is the length of the byte or the length of the character (possibly single/double byte), whether it starts at 0 or starts at 1?

A: The length of the byte, counted as 0.

(3) How is the boundary condition handled? How does the default of a switch statement work? Is there a possible cycle of loops?

A: Through the Baidu Query and ask students to solve.

(4) Is there an assertion (assert) to ensure that the conditions we think are not changed are really satisfied?

Answer: No.

(5) The use of resources, where is the application, where released? Is it possible to cause resource leaks (memory, files, various GUI resources, connections to database access, and so on)? Is there any possibility of optimization?

Answer: Find on the network.

(6) Are there any useless elements in the data structure?

Answer: No

5. Efficiency

(1) What is the performance of the Code (performance)? What is the worst case scenario?

A: The code is more complete, the program can be run out. The worst case scenario is that the form has an error and the code is faulty. The program will not work.

(2) in the code, in particular, whether there is a clearly-optimized part of the loop (the class is repeatedly created in C + +, the operation of string in C # can be optimized with StringBuilder)

Answer: Yes.

(3) Will the system and network calls time out? How to deal with?

Answer: Will not time out, problems arise through the network, teachers, books and other ways to solve.

6. Readability

How readable is the code? Is there enough comment?

A: People who are proficient in learning can read and have no comments.

7. Testability

Does the code need to update or create a new unit test?

You can also have checklists for specific areas of development (such as databases, Web pages, multithreading, and so on).

A: Not required.

Code Review Checklist