Basic software engineering jobs-personal project code review

I am reviewing the personal project code of Zuo Shaohui.

First of all, Zuo Shaohui's code has many advantages:

The style is good, most of them are concise and clear, and the relationship between methods is also very clear. There are still a lot of annotations, which are easy to understand, and many library functions are used to simplify the program, as shown below:

However, when you carefully observe the details, you will notice that this code still has many problems. Specifically, there are three:

1. First, too many local variables are defined in the breakword method. Some Variables cannot be named, such as FR and FN. In this way, the program's ease of use is reduced, and the program's simplicity is also reduced.

2. This program should be an object-oriented program, but there are too many process-oriented features in the sortword method of this program. It is simply that the noodle program keeps going.

3. The isequal method is too cumbersome to write. It can simplify the method or improve the efficiency of the algorithm.

To sum up, there are still a lot of improvements to be made in the above procedures.

My suggestions for improvement are as follows:

1. Improve algorithm efficiency so that you can write more beautiful and concise code.

2. Improve understanding of object-oriented languages, so as to avoid writing errors for process-oriented programs.

3. The style of writing code should be adjusted slightly. Do not name some local variables that others cannot understand. The name of the class method should also be noted, so that the readability of the program will be much stronger.

Basic software engineering jobs-personal project code review