Code Review (3)-Responsibility System

The emergence of the rural land contract responsibility system many years ago led to a fundamental change in the role of large farmers, which ushered in a huge improvement in food production and the lives of farmers. At the same time, in the Code rivew group activity, the most effective way to make it run is to assign certain responsibilities to a role at the same time. The following is a simple explanation of the Code Review and its process of the role in our group. I also want to share some ideas and views on codereview with the majority of software colleagues. Because it is the method of our company, there will also be deficiencies, you are welcome to discuss.

I. Code review role category
1. Author: the author of the review object.
2. Moderator: Generally, it is composed of experienced developers in the team.
3. RECORDER: Mainly used to record the entireCodeReview.
4. Reader (may be the same person as author or leader)
5. other reviewers: other members in the team, but generally do not have too many people, because for a discussion meeting, it is best to keep the participants within 7 people, in this way, this meeting is controllable.
The functions of these roles will change in the Code review without any stage.

 

Ii. Code review process and tasks of its roles in different stages

Shows the entire code review activity process. Generally, planning, preparation, meeting, rework & verfication are required in a code review activity, the overview stage varies with the review object. It is necessary for some review activities that work heavily. The following describes the tasks of each stage in detail, and the responsibilities of each role in the corresponding stage.

1. Planning:

This stage mainly involves determining the roles and personnel and determining whether the review object has reached the review stage, in this way, the overall efficiency of the review is too low because the code review is still under serious problems. There is also a general division of the entire review process. At this stage, author determines who will be the moderator of this review (generally, moderator can only be selected from a limited number of people in the team, not everyone can assume this role .) Then invite others to serve as recoder and other reviewers of this review;
The main tasks of each role in this phase are:
Author: make a plan for the entire review process, determine the participants in the rewview, and distribute the review materials to these members.
Moderator: analyzes the entire object for review to see if it meets the requirements for starting code review.

2. Overview:
If you are not familiar with a large number of projects that require review or most people who participate in review. Start a short website by author to solve the problem of review.

3. Preparation:

At this stage, all involved reviewers read the review items, record and submit the problems found, And Then author and moderator summarize the problems found by reviewers, classification and screening. Then, based on the summarized problems, we can further determine whether the review meeting is suitable for recruitment. If the summary contains many problems, the event will be canceled if the reivew file has not really met the requirements. Developed by author. If not many problems are found, open review meeting on time.

 

The main tasks of each role in this phase are:
Reviewers: Read the objects to be reviewed first, and then submit the problems discovered by them.
Moderator and Author: Summarize the issues submitted by reviewers to check whether the review conditions are met.

4. Meeting:

Meeting is the core and key part of the review. The main task is to host the summarized problems by author, analyze them one by one, and give your own judgment, whether to accept reviewers or not to accept the questions raised by reviewers. If there are still differences, moderator will decide whether to change the question. After analyzing all the summarized problems, author will take all the reviewers to read the code. Then we further analyze and discuss issues in the code.

 

The main tasks of each role in this phase are:
Author: analyze and summarize the problems one by one, and give your own analysis. Lead all reviewers to read the code;
Moderator: analyzes and judges whether author's analysis and determination of the problem is reasonable, and provides the handling suggestions for the different problems at critical moments;
Reviewers: discusses and analyzes the issues raised before, and performs collective re-reading of the Code to find more problems;
RECORDER: record the entire code review, including the detected problems and rectification suggestions.

 

5. rework & Verification:

In this phase, author rectifies the problems raised during the review process, and then submits them to Moderator to evaluate the overall rectification.

Summary:
By assigning roles to Members in the code review, you can improve their sense of responsibility and greatly improve the efficiency of code lookup.