Pkg/33325:imagemagick Broken with new PNG

Pkg/33325:graphics/imagemagick broken with new PNG

By '); -->b1ff '); --> APR 21, 2006; 09:20PM:: Rate This message:-use ratings to moderate (?)

Reply | Reply to Author | Print | View Threaded | Show only this message >number:         33325
>category:       PKG
>sy Nopsis:       Graphics/imagemagick broken with new png
> Confidential:   No
>severity:       non-critical
>priority:       Low
>responsible:    pkg-manager
>state:          open
>class:   &N Bsp      sw-bug
>submitter-id:   NET
>arrival-date:   Fri Apr 12:20:00 +0000 2006 >originator:     Mathieu
>release:        3.0.0_stable
>organization: Br>>environment: ... [show rest of quote]

NetBSD Sal.lan 3.0.0_stable NetBSD 3.0.0_stable (specific) #0: Sat APR 8 22:19:10 EDT 2006 Mathieu@...:/usr/src/sys/arch /i386/compile/specific i386
>description:
if/bin/sh./libtool--silent--tag=cc--mode=compile cc-dhave_config_h-i-I.-i./magick-i./wand-i./ltdl-i./ltdl- i/usr/pkg/include/freetype2-i/usr/pkg/include-i/usr/pkg/include-i/usr/include-i/usr/pkg/include/freetype2-i/ usr/pkg/gcc34/include-i/usr/pkg/xorg/include-i/usr/pkg/include/libxml2-o2-march=pentium4-pipe-i/usr/pkg/ INCLUDE-I/USR/INCLUDE-I/USR/PKG/INCLUDE/FREETYPE2-I/USR/PKG/GCC34/INCLUDE-WALL-MT coders/magick_libMagick_la-PNG. LO-MD-MP-MF "coders/.deps/magick_libmagick_la-PNG. Tpo "-c-o coders/magick_libmagick_la-PNG. Lo ' test-f ' coders/PNG. C ' | | echo './' coders/PNG. C; /
Then Mv-f "coders/.deps/magick_libmagick_la-PNG. Tpo "" coders/.deps/magick_libmagick_la-PNG. Plo "; else Rm-f "coders/.deps/magick_libmagick_la-PNG. Tpo "; Exit 1; Fi
coders/PNG. c:infunction' Readonepngimage ':
coders/PNG. c:1758:warning:Implicit DeclarationOffunction`png_access_version'
coders/PNG. C:1767:error: 'png_ptr' Undeclared (thefunction)
coders/PNG. C:1767:error: (each undeclared identifier are reported only once
coders/PNG. c:1767:error:for eachfunctionIt appears in.)
Gmake: * * * [coders/magick_libmagick_la-PNG. Lo] Error 1
Error Code 2

>how-to-repeat:
happens whenPNGis built with itsPNGGCCRDOptimization.

>fix:
---coders/PNG. C.orig 2006-03-24 14:45:40.000000000-0500
+++ coders/PNG. C 2006-04-21 07:54:59.000000000-0400
@@ -1755,7 +1755,7 @@
#if defined (PNG_USE_PNGGCCRD) && defined (png_assembler_code_supported) /
&& (Png_libpng_ver>= 10200)
/* Disable Thread-unsafe features ofPNGGCCRD*/
-if (png_access_version() >= 10200)
+ if (Png_access_version_number() >= 10200)
{
png_uint_32mmx_disable_mask=0;
png_uint_32Asm_flags;
@@ -1764,8 +1764,8 @@
|png_asm_flag_mmx_read_filter_sub/
|Png_asm_flag_mmx_read_filter_avg/
|Png_asm_flag_mmx_read_filter_paeth);
-asm_flags=Png_get_asm_flags(png_ptr);
-Png_set_asm_flags(png_ptr, Asm_flags & ~mmx_disable_mask);
+ asm_flags=Png_get_asm_flags(ping);
+Png_set_asm_flags(Ping, Asm_flags & ~mmx_disable_mask);
}
#endif

That chunk of code is taken literally from libpng (3), which also
Contains the bogus call topng_access_version().