Code Fragment-對於if語句中的boolean值分開判斷的處理。

來源:互聯網
上載者:User

本文參考自《代碼整潔之道》,這本書,非常好!

向方法中傳入boolean值參數,用於判斷邏輯並分開執行。缺點:

  • 方法簽名立即變得複雜起來。
  • 此方法做的事情多餘一件。

執行個體:

    /**     * @param isChecked     */    protected void setAllDayViewsVisibility(boolean isChecked) {        if (isChecked) {            if (mEndTime.hour == 0 && mEndTime.minute == 0) {                mEndTime.monthDay--;                long endMillis = mEndTime.normalize(true);                // Do not allow an event to have an end time                // before the                // start time.                if (mEndTime.before(mStartTime)) {                    mEndTime.set(mStartTime);                    endMillis = mEndTime.normalize(true);                }                setDate(mEndDateButton, endMillis);                setTime(mEndTimeButton, endMillis);            }            mStartTimeButton.setVisibility(View.GONE);            mEndTimeButton.setVisibility(View.GONE);            mTimezoneRow.setVisibility(View.GONE);        } else {            if (mEndTime.hour == 0 && mEndTime.minute == 0) {                mEndTime.monthDay++;                long endMillis = mEndTime.normalize(true);                setDate(mEndDateButton, endMillis);                setTime(mEndTimeButton, endMillis);            }            mStartTimeButton.setVisibility(View.VISIBLE);            mEndTimeButton.setVisibility(View.VISIBLE);            mTimezoneRow.setVisibility(View.VISIBLE);        }        updateHomeTime();    }

重構以後,變成2個方法

protected void setAllDayViewsGone() {if (mEndTime.hour == 0 && mEndTime.minute == 0) {mEndTime.monthDay--;long endMillis = mEndTime.normalize(true);// Do not allow an event to have an end time// before the// start time.if (mEndTime.before(mStartTime)) {mEndTime.set(mStartTime);endMillis = mEndTime.normalize(true);}setDate(mEndDateButton, endMillis);setTime(mEndTimeButton, endMillis);}mStartTimeButton.setVisibility(View.GONE);mEndTimeButton.setVisibility(View.GONE);mTimezoneRow.setVisibility(View.GONE);updateHomeTime();}protected void setAllDayViewsVisible() {if (mEndTime.hour == 0 && mEndTime.minute == 0) {mEndTime.monthDay++;long endMillis = mEndTime.normalize(true);setDate(mEndDateButton, endMillis);setTime(mEndTimeButton, endMillis);}mStartTimeButton.setVisibility(View.VISIBLE);mEndTimeButton.setVisibility(View.VISIBLE);mTimezoneRow.setVisibility(View.VISIBLE);updateHomeTime();}

聯繫我們

該頁面正文內容均來源於網絡整理,並不代表阿里雲官方的觀點,該頁面所提到的產品和服務也與阿里云無關,如果該頁面內容對您造成了困擾,歡迎寫郵件給我們,收到郵件我們將在5個工作日內處理。

如果您發現本社區中有涉嫌抄襲的內容,歡迎發送郵件至: info-contact@alibabacloud.com 進行舉報並提供相關證據,工作人員會在 5 個工作天內聯絡您,一經查實,本站將立刻刪除涉嫌侵權內容。

A Free Trial That Lets You Build Big!

Start building with 50+ products and up to 12 months usage for Elastic Compute Service

  • Sales Support

    1 on 1 presale consultation

  • After-Sales Support

    24/7 Technical Support 6 Free Tickets per Quarter Faster Response

  • Alibaba Cloud offers highly flexible support services tailored to meet your exact needs.