Personal Assignment 2---Pair programming object code review

General

1.Does The code work? Does It perform it intended function, the logic is correct etc.

Visually from the results, the results of the operation is good, if the input format indicated in the job requirements to set parameters, the output is basically in line with expectations. And it feels better than my program.

2.Is all the code easily understood?

The whole idea and my program is similar, is also generated, turn suffix recalculation, so very good to understand.

3.Does it conform to your agreed coding conventions? These would usually cover location of braces, variable and function names, line length,

Not quite in line with, feeling style is not very good. It's best to have a space between binary operators. Look at the clear point, and then the name is not very good, not too can have a certain meaning.

4.Is there any redundant or duplicate code?

It feels like there are too many branches to generate expressions in the Main function, and some can be properly merged into internal branches.

5.Is the code as modular as possible?

It basically conforms to the requirements of modular programming, but the feeling of the generated parts is not as independent as the Main function.

Security

1.Are all data inputs checked (for the correct type, length, format, and range) and encoded?

This is not done, but the teacher also seems to mention in the homework requirements this time does not involve the detection of the legitimacy of the input.

2.Are output values checked and encoded?

Check over, no encode ...

3.Are invalid parameter values handled?

No, same 1 .

Documentation

1.Do comments exist and describe the intent of the code?

No comments at all!

2.Are all functions commented?

No comments at all!

Because there is no requirement to write a document, the following items are not.

Testing

1 This part of the content should be displayed by the author, but because there is no project submitted as a job, so there is no way to talk about it.

Personal Assignment 2---Pair programming object code review