IOS Modify Address Book contact addresses crash cause analysis

In the current project, the iOS system address book needs to be read, modified operation. At the time of the address modification, there was a strange phenomenon:

If the contact does not have an address field (or a brand new contact), it is possible to modify its address to be successful.

If the person has an address field, the modification will crash when it is done. Console typing:

-[cfstring release]: message sent to deallocated instance 0x81d26f0

This should be a zombie object that repeats the release of an object. First I check the code to modify the Address book, but I do not see the problem, the following is the code

[OBJC]View Plaincopy

2. Set address
4. Abmutablemultivalueref multiaddress = abmultivaluecreatemutable (Kabmultidictionarypropertytype);
6. For (phonetypepair* p in contact. Addressarr) {
8. //Content judgment null
10. if ([P. Content length]==0) {
12. continue;
14. }
16. nsmutabledictionary *addressdictionary = [[Nsmutabledictionary alloc] init];
18. //address is written to the street field only
20. [Addressdictionary setobject:[p. Content Mutablecopy] forkey: (NSString *)  Kabpersonaddressstreetkey];
22. [Addressdictionary SetObject:@ "" forkey: (NSString *) Kabpersonaddresscitykey];
24. [Addressdictionary SetObject:@ "" forkey: (NSString *) Kabpersonaddressstatekey];
26. [Addressdictionary SetObject:@ "" forkey: (NSString *) Kabpersonaddresszipkey];
28. [Addressdictionary SetObject:@ "" forkey: (NSString *) Kabpersonaddresscountrycodekey];
30. //Put the dictionary into a multi-valued object
32. if ([P. Type isequaltostring:kaddresstype_work]) {
34. Abmultivalueaddvalueandlabel (Multiaddress, Cfbridgingretain (addressdictionary), Kabworklabel, NULL);
36. }Else if ([P. Type Isequaltostring:kaddresstype_home]) {
38. Abmultivalueaddvalueandlabel (Multiaddress, Cfbridgingretain (addressdictionary), Kabhomelabel, NULL);
40. }else{
42. Abmultivalueaddvalueandlabel (Multiaddress, Cfbridgingretain (addressdictionary), Kabotherlabel, NULL);
44. }
46. }
48. Abrecordsetvalue (person, Kabpersonaddressproperty, multiaddress, NULL);
50. Abaddressbookaddrecord (addressbook, person, nil);
52. Abaddressbooksave (AddressBook, NULL);
54. if (multiaddress) {
56. Cfrelease (multiaddress);
58. }

Program crashes in Abaddressbooksave (AddressBook, NULL); Best of all, Google looked at a lot of information to see if the "multi-value" of the object used wrong, or code order problem. Have no results.

Later, I remember instruments this tool to view zombie objects. Immediately starting profile. The results are as follows:

The place of Zombie is Abcmultivaluedestroy. However, I have noticed Addressbookengine's getaddress: function. Suddenly I realized that the problem should be read when the CF and OC objects were converted. Randomly, I opened the URL and turned to arc description

__bridge only does type conversion, but does not modify the object (memory) management rights;
__bridge_retained (You can also use Cfbridgingretain) to convert objects from Objective-c to core foundation objects while handing over the management of the object (memory) to us, Subsequent use of cfrelease or related methods to release objects;
__bridge_transfer (You can also use cfbridgingrelease) to convert a core foundation object to an Objective-c object while handing over the management of the object (memory) to arc.

Well, the problem should be reading the address: Look at the code.

[OBJC]View Plaincopy

2. /**
4. * Get Address
6. *
8. * @param recordref contacts Single Contact reference
10. *
12. * @return Address
14. */
16. -(nsdictionary*) getaddress: (abrecordref) recordref{
18. //1. Judgment
20. if (recordref = = nil) {
22. return Nil;
24. }
26. Nsmutablearray *addresshome = [[Nsmutablearray alloc]init];
28. Nsmutablearray *addresswork = [[Nsmutablearray alloc]init];
30. Nsmutablearray *other = [[Nsmutablearray alloc]init];
32. //2. Creating a dictionary to get a list of multi-key values
34. nsmutabledictionary *multivaluedic = [[Nsmutabledictionary alloc] initwithcapacity:1];
36. Abmultivalueref Multivaluearr = Abrecordcopyvalue (RecordRef, Kabpersonaddressproperty);
38. //3. Encapsulates multiple values into a dictionary.
40. int count = Multivaluearr?  Abmultivaluegetcount (Multivaluearr): 0;
42. if (Count > 0) {
44. Count = (count <= kmaxaddressnumber?count:kmaxaddressnumber);
46. For (int i = 0; i < count; i++) {
48. @autoreleasepool {
50. //lable
52. //Pay attention to bridging, convert CF object to OC object. Under Arc, the OC object is automatically released: Reference http://blog.csdn.net/hherima/article/details/16356577
54. nsstring* label = Cfbridgingrelease (Abmultivaluecopylabelatindex (multivaluearr,i));
58. //value
60. Cfdictionaryref dict = Abmultivaluecopyvalueatindex (Multivaluearr, i);
62. nsstring* Street =cfbridgingrelease (Cfdictionarygetvalue (Dict, Kabpersonaddressstreetkey));
64. nsstring* City =cfbridgingrelease (Cfdictionarygetvalue (Dict, Kabpersonaddresscitykey));
66. nsstring* Country =cfbridgingrelease (Cfdictionarygetvalue (Dict, Kabpersonaddresscountrykey));
68. //cfrelease (dict);//should be deleted
72. nsstring *syntheticaddress = [NSString stringwithformat:@ "%@%@%@"
74. , (Street?street:@ "")
76. , (city?city:@ "")
78. , (country?country:@ "")];
82. if (label = = Nil | | [Label isequaltostring:@ "_$!
84. [Addresshome addobject:syntheticaddress];
86. }
88. Else if ([Label isequaltostring:@ "_$!<work>!$_"]) {
90. [Addresswork addobject:syntheticaddress];
92. }
94. else{
96. [Other addobject:syntheticaddress];
98. }
102. }
104. }
106. [Multivaluedic setobject:addresshome forkey:@ (eadressbooktype_addresshome)];
108. [Multivaluedic setobject:addresswork forkey:@ (eadressbooktype_addresswork)];
110. [Multivaluedic setobject:other forkey:@ (eadressbooktype_addressother)];
112. }
114. //4. Releasing a CF object
116. if (NULL! = Multivaluearr) {
118. Cfrelease (Multivaluearr);
120. Multivaluearr = NULL;
122. }
126. return multivaluedic;
128. }

I made a hypothesis before I could find a specific question. If you return from the beginning of this function, if you do not crash, the explanation is the problem of subsequent code. Sure enough

The problem is:

Cfrelease (DICT);

Since I have used the cfbridgingrelease, it is not necessary to releasedict this object. The main is the above code, is copy from the Internet. No change.

http://blog.csdn.net/hherima/article/details/41594273

IOS Modify Address Book contact addresses crash cause analysis