Code Daquan: review and inspection

Chapter 2 Collaborative construction talked about review and inspection, which resonated with each other and reminded me of the good time I spent working in my company.

In the company, project code is common, and it is no exception to our part-time students. The first thing to do at work every day is to update and retrieve the latest code base from depot (we call it sync, which is the command of our version control software ). Before checking in, you must find the review code of the person in the same project team. I am also often called for review code. This is a very effective practice. It is not because of the number of errors that review can discover. It is only because someone will review the code written by themselves later, so be careful when writing the code to avoid errors. There are no detailed rules on the number of checkin requests. Everyone should avoid the code out of sync in their hands for too long. Generally, check in once or twice a day. Reviewed by whom must be specified for each check in.

Review is an informal check. Inspection is a formal check.

We have an inspection (Code Review) about once a week. The participants in the inspection are generally from our own project team, along with about the same number of other project team members, A total of more than 10 people will make an appointment in advance for a small meeting room (several of our interns. First, determine the code of the review and the code of the Review, print the code in advance (there must be a row number if there are less than 10 A4 pages), and copy it to everyone. Let's take a look at it. We will discuss it in the meeting room later. The discussion lasts about two hours. This article discusses both the code design and the advantages and disadvantages of specific statements. Because the code has been read in advance, some people will give their opinions at the beginning. As the discussion goes on, new opinions will be put forward, which is basically not a cold spot. This is a good time for technical exchanges across the entire group. You can also hear comments from other groups.

Code Daquan also advocates this collaboration method (of course many other collaboration methods mentioned in the book), which is an effective way to improve product quality.