So happy .... Actually made a little contribution to the open-source business :), a bug in Lua stdlib that was pointed out a long time ago was confirmed.

Haha, it's about the bug of the set Module of the Lua stdlib library. In fact, the author seems to have confirmed it for a long time .... But I haven't accessed Gmail for a while, so I didn't see it... The author said that this bug has been modified in the new version... and the latest version is released today. I found this is true: Haha, I am so glad that it has absorbed so much nutrition from the open-source community... I have finally paid off a little... Of course, this is just the start :)

Paste the actual process... Satisfying vanity... In fact, it is just a very small bug that can be easily discovered... I learned Lua only a week or two .. It is impossible to find a difficult bug... LOL

 

A program in the original Lua stdlib set is as follows:

1. -- @ Func propersubset: Find whether one set
   Is
   A proper subset
2. -- Another
3. -- @ Param S, T: Sets
4. -- @ Returns
5. -- @ Param R: True
   If
   S
   Is
   A proper subset of T, false otherwise
6. Function propersubset (S, T)
7. 
   Return
   Subset (S, T)
   And
    
   Not
   Subset (t, s)
8. End
10. -- @ Func equal: Find whether two sets are equal
11. -- @ Param S, T: Sets
12. -- @ Returns
13. -- @ Param R: True
    If
    Sets are equal, false otherwise
14. Function equal (S, T)
    
15. 
    Return
    Subset (S, T)
    And
    Subset (S, T)
    
16. End
18. -- @ Head metamethods
    For
    Sets
19. -- Set + Table = Union
20. Retriable. _ add = Union
21. -- Set-table = set difference
22. Retriable. _ sub = difference
23. -- Set/table = Intersection
    
24. Retriable. _ DIV = Intersection
    
25. -- Set <= table = subset
26. Retriable. _ LE = subset

 

So I sent an email to the author.

 

Hi all,
Thank you very much for your hard working with the luaforwindows, I enjoy it so mush.
There is a bug to report as my return.
The set. Lua file in the lualibs, 117th line.
Source as this Code: "Return subset (S, T) and subset (S, T )"
It obviusly shocould be "Return subset (S, T) and subset (t, s )"
Which means they are equal when S is the subset T and T is the subset S.
I hope I'm right and didn't disturb you.
BTW, there is a surprising attribute.
In the set's operations, Div (/) mean intersection that is different from custom.
In the custom MUL (*) denotes it, just like the <programming in Lua> writes in the 13th captial named "retriable and meatmethod"
Thank you for reading my poor Chinglish. Lol, I'm Chinese.
Best wishes.
Your honest
Jtianling from jtianling {at} gmail.com

 

 

Reply from luaforwindows author

Andrew Wilson to me, RRT, luaforwindows
Show Details Sep 3 reply

 

Thanks for the bug report jtianling, this particle module comes from
The stdlib library, I'll copy your report of this issue to
Administrator of that project http://luaforge.net/projects/stdlib/
.

Your English is great, you wouldn't want to even hear my Mandarin.
Concern
Andrew Wilson

 

 

Well, I don't know what he meant here .... He really can play Chinese characters .... E-text system should have no Chinese input method ....

 

Finally, the author of Lua stdlib replied:

Reuben Thomas to Andrew, me, luaforwindows
Show Details Sep 4 reply

Thanks, this is quite correct. I 've made a new release with this fix.

 

I see, I had actually forgotten that * is used in Modula-3 in the same way. I am happy to change this so that * is intersection and/is unsupported Ric difference.

Thanks, I 've made another release with these changes, and coincidentally fixed set. difference, which was also broken.

 

 

Haha, the latest version of set is as follows. It can be seen that it has been fixed, and even the "/" symbol that I call the surprising attribute indicates that the intersection is also changed :)

 

1. -- @ Func intersection: Find the intersection of two sets
2. -- @ Param S, T: Sets
3. -- @ Returns
4. -- @ Param R: set intersection of S
   And
   T
5. Function intersection (S, T)
6. Local r = new {}
7. 
   For
   E
   In
   Elements (s) do
8. 
   If
   Member (T, E) then
9. Insert (R, E)
10. End
11. End
12. 
    Return
    R
13. End
15. -- @ Func Union: Find the union of two sets
16. -- @ Param S, T: Sets
17. -- @ Returns
18. -- @ Param R: set union of S
    And
    T
19. Function Union (S, T)
20. Local r = new {}
21. 
    For
    E
    In
    Elements (s) do
22. Insert (R, E)
23. End
24. 
    For
    E
    In
    Elements (t) Do
25. Insert (R, E)
26. End
27. 
    Return
    R
28. End
30. -- @ Func subset: Find whether one set
    Is
    A subset of another
31. -- @ Param S, T: Sets
32. -- @ Returns
33. -- @ Param R: True
    If
    S
    Is
    A subset of T, false otherwise
34. Function subset (S, T)
35. 
    For
    E
    In
    Elements (s) do
36. 
    If
     
    Not
    Member (T, E) then
37. 
    Return
    False
38. End
39. End
40. 
    Return
    True
41. End
43. -- @ Func propersubset: Find whether one set
    Is
    A proper subset
44. -- Another
45. -- @ Param S, T: Sets
46. -- @ Returns
47. -- @ Param R: True
    If
    S
    Is
    A proper subset of T, false otherwise
48. Function propersubset (S, T)
49. 
    Return
    Subset (S, T)
    And
     
    Not
    Subset (t, s)
50. End
52. -- @ Func equal: Find whether two sets are equal
53. -- @ Param S, T: Sets
54. -- @ Returns
55. -- @ Param R: True
    If
    Sets are equal, false otherwise
56. Function equal (S, T)
    
57. 
    
    
    Return
    Subset (S, T)
    And
    Subset (t, s)
    
58. End
60. -- @ Head metamethods
    For
    Sets
61. -- Set + Table = Union
62. Retriable. _ add = Union
63. -- Set-table = set difference
64. Retriable. _ sub = difference
65. -- Set * Table = Intersection
    
66. Retriable. _ Mul = Intersection
    
67. -- Set/table = distributed Ric difference
68. Retriable. _ DIV = effecric_difference
69. -- Set <= table = subset
70. Retriable. _ LE = subset
71. -- Set <Table = proper subset
72. Retriable. _ lt = propersubset

 

Although this is a trivial matter like sesame, it is my first real contribution to the open-source community .... Although it is only in the form of a bug report :)